Writing RPM macro for OpenStack

RPM macro is a short string, always prefixed by % and generally surrounded by curly brackets ({}) which RPM will convert to a different and usually longer string.
Some macros can take arguments and some can be quite complex.
In RHEL, CentOS and Fedora, macros are provided by rpm package and from redhat-rpm-config.
In , OpenStack macros are provided by openstack-macros which comes from upstream rpm-packaging project.
You can find list of all macros under /usr/lib/rpm/macros.d/ directory.

To see the list of all available macros on your system:

$ rpm –showrc

For example: %{_bindir} is a rpm-macro which points to the binary directory where executables are usually stored.

To evaluate an rpm macro:

$ rpm –eval %{_bindir}

%py_build is the commonly used rpm-macro in RDO OpenStack packages which points to python setup.py build process.

$ rpm –eval %py_build

Motivation behind writing a new RPM macro for OpenStack packages
Currently, Tempest provides an external test plugin interface which enables anyone to integrate an external test suite as a part of Tempest run and each service Tempest plugin has an entrypoint
defined in setup.cfg through which tempest discovers it and list the Tempest plugins.
For example:

tempest.test_plugins =
heat_tests = heat_integrationtests.plugin:HeatTempestPlugin

In RDO OpenStack services RPM packages, In-tree Tempest plugins packages are provided by openstack-{service}-tests subpackage but the tempest plugin entrypoint is provided by the main package openstack-%{service}.
So once you have a working OpenStack environment with Tempest installed having no test subpackage installed. Then we tried to run tempest commands you would have encountered “No module heat_integrationtests.plugin found”
and you end up installing a hell lot of packages to fix this. The basic reason for the above error is tempest plugin entry point is installed by main OpenStack package but files pointing to entrypoint are not found.

To fix the above issue we have decided to separate out the tempest plugin entrypoint from the main package and move it to openstack-{service}-tests subpackage during rpmbuild process by creating a fake tempest plugin entry point
for all RDO services packages. Since it is a massive and similar change affecting all OpenStack services packages.
So, I have created %py2_entrypoint macro which is available in OpenStack Ocata release.
Here is the macro definition of %py2_entrypoint:
“`
# Create a fake tempest plugin entry point which will
# resides under %{python2_sitelib}/%{service}_tests.egg-info.
# The prefix is %py2_entrypoint %{modulename} %{service}
# where service is the name of the openstack-service or the modulename
# It should used under %install section
# the generated %{python2_sitelib}/%{service}_tests.egg-info
# will go under %files section of tempest plugin subpackage
# Example: %py2_entrypoint %{modulename} %{service}
# In most of the cases %{service} is same as %{modulename}
# but in case of neutron plugins it is different
# like servicename is neutron-lbaas and modulename is neutron_lbass
%py2_entrypoint()
egg_path=%{buildroot}%{python2_sitelib}/%{1}-*.egg-info
tempest_egg_path=%{buildroot}%{python2_sitelib}/%{1}_tests.egg-info
mkdir $tempest_egg_path
grep “tempest|Tempest” %{1}.egg-info/entry_points.txt >$tempest_egg_path/entry_points.txt
sed -i “/tempest|Tempest/d” $egg_path/entry_points.txt
cp -r $egg_path/PKG-INFO $tempest_egg_path
sed -i “s/%{2}/%{1}_tests/g” $tempest_egg_path/PKG-INFO
%nil

“`
Here is the list of tempest-plugin-entrypoint reviews.

Some learning from above macro:

[1.] You can use the shell script or Lua language to write macros.

[2.] %define is used to define a macro in spec file or you can directly place the macro in /usr/lib/rpm/macros.d/macros.openstack-rdo to consume it using rpmbuild process.

[3.] use %nil to showcase the end of the macro.

[4.] use %{1} to %{6} to pass variables in macros.

Above is a temporary solution. We are working upstream to separate out tempest plugins from OpenStack project to a new repo for easier management and packaging
in Pike release:https://review.openstack.org/#/c/405416/.

Thanks to Daniel, Alan Haikel and many others on rdo channel for getting the work done.
It was a great learning experience.
Quelle: RDO

Published by